On Mon, Mar 16, 2020 at 7:43 PM Kunihiko Hayashi
[off-list ref] wrote:

On Sat, 14 Mar 2020 11:14:09 +0900 [off-list ref] wrote:

quoted

On Fri, Mar 13, 2020 at 9:58 AM Kunihiko Hayashi
[off-list ref] wrote:

quoted

Add external DMA controller support implemented in UniPhier SoCs.
This supports for Pro4, Pro5 and PXs2.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 arch/arm/boot/dts/uniphier-pro4.dtsi | 8 ++++++++
 arch/arm/boot/dts/uniphier-pro5.dtsi | 8 ++++++++
 arch/arm/boot/dts/uniphier-pxs2.dtsi | 8 ++++++++
 3 files changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/uniphier-pro4.dtsi b/arch/arm/boot/dts/uniphier-pro4.dtsi
index 2ec04d7..a1bfe0f 100644
--- a/arch/arm/boot/dts/uniphier-pro4.dtsi
+++ b/arch/arm/boot/dts/uniphier-pro4.dtsi

@@ -426,6 +426,14 @@
                        };
                };

+               xdmac: dma-controller@5fc10000 {
+                       compatible = "socionext,uniphier-xdmac";
+                       reg = <0x5fc10000 0x1000>, <0x5fc20000 0x800>;

This is odd.
<0x5fc20000 0x800> causes reg overwrap with
aidet@5fc20000 below.

Thank you for pointing out.

Indeed, the address is wrong. I'll fix it.
And I'll also fix the example of dt-bindings.

Thank you,

You did not notice the over-wrap
because the second region is not used
from the driver.

Why did you define the unused region?


--
Best Regards
Masahiro Yamada

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel