Thread (10 messages) 10 messages, 3 authors, 2020-04-01

Re: [PATCH 3/4] clk / soc: mediatek: Bind clock and gpu driver for mt2701

From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: 2020-03-31 23:28:34
Also in: linux-clk, linux-mediatek, lkml

Hi, Enric:

Enric Balletbo i Serra [off-list ref] 於 2020年4月1日 週三 上午5:47寫道:
Now that the mmsys driver is the top-level entry point for the
multimedia subsystem, we could bind the clock and the gpu driver on
those devices that is expected to work, so the drm driver is
intantiated by the mmsys driver and display, hopefully, working again.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
quoted hunk ↗ jump to hunk
Signed-off-by: Enric Balletbo i Serra <redacted>
---
If you have this hardware, please kindly provide your tested tag. Only
build tested.

 drivers/clk/mediatek/clk-mt2701-mm.c | 8 ++------
 drivers/soc/mediatek/mtk-mmsys.c     | 8 ++++++++
 2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/mediatek/clk-mt2701-mm.c b/drivers/clk/mediatek/clk-mt2701-mm.c
index 054b597d4a73..3a4e895a3d0f 100644
--- a/drivers/clk/mediatek/clk-mt2701-mm.c
+++ b/drivers/clk/mediatek/clk-mt2701-mm.c
@@ -79,16 +79,12 @@ static const struct mtk_gate mm_clks[] = {
        GATE_DISP1(CLK_MM_TVE_FMM, "mm_tve_fmm", "mm_sel", 14),
 };

-static const struct of_device_id of_match_clk_mt2701_mm[] = {
-       { .compatible = "mediatek,mt2701-mmsys", },
-       {}
-};
-
 static int clk_mt2701_mm_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
+       struct device_node *node = dev->parent->of_node;
        struct clk_onecell_data *clk_data;
        int r;
-       struct device_node *node = pdev->dev.of_node;

        clk_data = mtk_alloc_clk_data(CLK_MM_NR);
diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index c7d3b7bcfa32..cacafe23c823 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -80,6 +80,10 @@ struct mtk_mmsys_driver_data {
        const char *clk_driver;
 };

+static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
+       .clk_driver = "clk-mt2701-mm",
+};
+
 static const struct mtk_mmsys_driver_data mt2712_mmsys_driver_data = {
        .clk_driver = "clk-mt2712-mm",
 };
@@ -323,6 +327,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
 }

 static const struct of_device_id of_match_mtk_mmsys[] = {
+       {
+               .compatible = "mediatek,mt2701-mmsys",
+               .data = &mt2701_mmsys_driver_data,
+       },
        {
                .compatible = "mediatek,mt2712-mmsys",
                .data = &mt2712_mmsys_driver_data,
--
2.25.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help