On 2020/3/24 22:19, Martin Blumenstingl wrote:

On Tue, Mar 24, 2020 at 3:17 PM Neil Armstrong [off-list ref] wrote:

quoted

On 24/03/2020 15:13, Martin Blumenstingl wrote:

quoted

Hi Neil,

On Tue, Mar 24, 2020 at 11:20 AM Neil Armstrong [off-list ref] wrote:
[...]

quoted

+static const char *meson_a1_phy_names[] = {
+       "usb2-phy0", "usb2-phy1"
+};

my understanding is that the A1 SoC only has usb2-phy1.
+Cc Hanjie Lin to confirm this

I forgot a comment here, it only has a single PHY, but still the 2 U2 PHY
controls slots... it would need a large amount of code to handle this
tweak, and leaving 2 PHYs keeps the behavior before the patchset.

I just reviewed patch #3 and I now understand that it would require a
large code-change
I'm fine with a comment


Martin

.

I see, 
A comment here will be more comprehensible.

Acked-by: Hanjie Lin <redacted>

Hanjie


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel