Thread (12 messages) 12 messages, 4 authors, 2020-03-23

Re: [PATCH v3 2/2] pinctrl: stm32: Add level interrupt support to gpio irq chip

From: Marek Vasut <marex@denx.de>
Date: 2020-03-23 19:04:29
Also in: linux-gpio, lkml

On 2/20/20 10:17 AM, Marc Zyngier wrote:
On 2020-02-20 09:04, Linus Walleij wrote:
quoted
On Wed, Feb 19, 2020 at 3:32 PM Alexandre Torgue
[off-list ref] wrote:
quoted
GPIO hardware block is directly linked to EXTI block but EXTI handles
external interrupts only on edge. To be able to handle GPIO interrupt on
level a "hack" is done in gpio irq chip: parent interrupt (exti irq
chip)
is retriggered following interrupt type and gpio line value.

Signed-off-by: Alexandre Torgue <redacted>
Tested-by: Marek Vasut <marex@denx.de>
Reviewed-by: Linus Walleij <redacted>

If Marc want to merge it with patch 1/2 go ahead!
I'll queue the whole thing for 5.7.
I have a feeling this doesn't work with threaded interrupts.

If the interrupt handler runs in a thread context, the EOI will happen
almost right away (while the IRQ handler runs) and so will the code
handling the IRQ retriggering. But since the IRQ handler still runs and
didn't return yet, the retriggering doesn't cause the IRQ handler to be
called again once it finishes, even if the IRQ line is still asserted.
And that could result in some of the retriggers now happening I think.
Or am I doing something wrong ?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help