Thread (3 messages) 3 messages, 3 authors, 2020-03-19

Re: [PATCH] clk: imx: clk-pllv3: Use readl_poll_timeout() for PLL lock wait

From: Stephen Boyd <sboyd@kernel.org>
Date: 2020-03-19 19:58:55
Also in: linux-clk, lkml

Quoting Anson Huang (2020-03-17 20:26:44)
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
index df91a82..3dfa9c3 100644
--- a/drivers/clk/imx/clk-pllv3.c
+++ b/drivers/clk/imx/clk-pllv3.c
@@ -53,23 +56,14 @@ struct clk_pllv3 {
 
 static int clk_pllv3_wait_lock(struct clk_pllv3 *pll)
 {
-       unsigned long timeout = jiffies + msecs_to_jiffies(10);
        u32 val = readl_relaxed(pll->base) & pll->power_bit;
 
        /* No need to wait for lock when pll is not powered up */
        if ((pll->powerup_set && !val) || (!pll->powerup_set && val))
                return 0;
 
-       /* Wait for PLL to lock */
-       do {
-               if (readl_relaxed(pll->base) & BM_PLL_LOCK)
-                       break;
-               if (time_after(jiffies, timeout))
-                       break;
-               usleep_range(50, 500);
-       } while (1);
-
-       return readl_relaxed(pll->base) & BM_PLL_LOCK ? 0 : -ETIMEDOUT;
+       return readl_poll_timeout(pll->base, val, val & BM_PLL_LOCK, 500,
Did you want to use readl_relaxed_poll_timeout() to keep it the same as
before?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help