RE: [PATCH v5 1/7] PCI: rcar: Rename pcie-rcar.c to pcie-rcar-host.c

Hi Yoshihiro-San,

Thank you for the review.

-----Original Message-----
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Sent: 17 March 2020 06:59
To: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cc: Andrew Murray <redacted>; linux-pci@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-renesas-soc@vger.kernel.org;
linux-rockchip@lists.infradead.org; linux-kernel@vger.kernel.org;
devicetree@vger.kernel.org; Bjorn Helgaas [off-list ref]; Rob
Herring [off-list ref]; Mark Rutland [off-list ref];
Catalin Marinas [off-list ref]; Will Deacon [off-list ref];
Kishon Vijay Abraham I [off-list ref]; Lorenzo Pieralisi
[off-list ref]; Arnd Bergmann [off-list ref]; Greg
Kroah-Hartman [off-list ref]; Jingoo Han
[off-list ref]; Gustavo Pimentel
[off-list ref]; Marek Vasut
[off-list ref]; Shawn Lin <shawn.lin@rock-
chips.com>; Heiko Stuebner [off-list ref]; Prabhakar Mahadev Lad
[off-list ref]
Subject: RE: [PATCH v5 1/7] PCI: rcar: Rename pcie-rcar.c to pcie-rcar-host.c

Hi Prabhakar-san,

Thank you for the patch!

quoted

From: Lad Prabhakar, Sent: Saturday, February 29, 2020 12:41 AM

Since your email account is different with the Singed-off-by, I think you
should add your From: tag here like your v2 patch series.

quoted

This commit renames pcie-rcar.c to pcie-rcar-host.c in preparation for
adding support for endpoint mode. CONFIG_PCIE_RCAR is also renamed to
CONFIG_PCIE_RCAR_HOST to match the driver name accordingly.

In addition to this defconfig file has also been updated to match the
new config option.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-

lad.rj@bp.renesas.com>

quoted

---
 arch/arm64/configs/defconfig                             | 2 +-
 drivers/pci/controller/Kconfig                           | 7 ++++---
 drivers/pci/controller/Makefile                          | 2 +-
 drivers/pci/controller/{pcie-rcar.c => pcie-rcar-host.c} | 0
 4 files changed, 6 insertions(+), 5 deletions(-)  rename
drivers/pci/controller/{pcie-rcar.c => pcie-rcar-host.c} (100%)

diff --git a/arch/arm64/configs/defconfig

b/arch/arm64/configs/defconfig index 0f21288..7a34fce 100644

--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig

@@ -185,7 +185,7 @@ CONFIG_HOTPLUG_PCI=y

CONFIG_HOTPLUG_PCI_ACPI=y

quoted

CONFIG_PCI_AARDVARK=y  CONFIG_PCI_TEGRA=y -

CONFIG_PCIE_RCAR=y

quoted

+CONFIG_PCIE_RCAR_HOST=y

I think you should separate this change.
To avoid this, I have an idea in the Kconfig like below:
 - adding PCIE_RCAR_HOST.
 - keeping PCIE_RCAR and select PCIE_RCAR_HOST here.
 - adding a description in the help of PCIE_RCAR like "This will be removed
after defconfig is updated" is better.

The following is a sample. What do you think?

Sound like a plan will do that, I will just append the description "This will be removed
after defconfig is updated" to PCIE_RCAR config option.

Cheers,
--Prabhakar

Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel