Hi Robert,

On Fri, Mar 13, 2020 at 8:04 AM Robert Foss [off-list ref] wrote:

+static int __ov8856_power_on(struct ov8856 *ov8856)
+{
+       struct i2c_client *client = v4l2_get_subdevdata(&ov8856->sd);
+       int ret;
+
+       ret = clk_prepare_enable(ov8856->xvclk);
+       if (ret < 0) {
+               dev_err(&client->dev, "failed to enable xvclk\n");
+               return ret;
+       }
+
+       gpiod_set_value_cansleep(ov8856->reset_gpio, GPIOD_OUT_HIGH);

The parameter of gpiod_set_value_cansleep() is typically 0 (inactive
state) or 1 (active state), so:

 gpiod_set_value_cansleep(ov8856->reset_gpio, 1);

+
+       ret = regulator_bulk_enable(ARRAY_SIZE(ov8856_supply_names),
+                                   ov8856->supplies);
+       if (ret < 0) {
+               dev_err(&client->dev, "failed to enable regulators\n");
+               goto disable_clk;
+       }
+
+       gpiod_set_value_cansleep(ov8856->reset_gpio, GPIOD_OUT_LOW);

and here it should be:

gpiod_set_value_cansleep(ov8856->reset_gpio, 0);

Also, don't you need a reset period between the two?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel