Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
From: Joe Perches <joe@perches.com>
Date: 2020-03-12 09:39:18
Also in:
linux-serial, lkml
On Thu, 2020-03-12 at 18:02 +0900, Masahiro Yamada wrote:
On Thu, Mar 12, 2020 at 5:56 PM Greg Kroah-Hartman [off-list ref] wrote:quoted
On Wed, Mar 11, 2020 at 07:31:07AM -0700, Joe Perches wrote:quoted
On Wed, 2020-03-11 at 14:15 +0900, Masahiro Yamada wrote:quoted
On Wed, Mar 11, 2020 at 2:07 PM Joe Perches [off-list ref] wrote:quoted
Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches <joe@perches.com>Acked-by: Masahiro Yamada <redacted> But, I think the patch subject should be prefixed: "serial: 8250_uniphier:"Yeah thanks, that's difficult to script though.Kernel development is hard :)It is strange to process this per-platform and to send out a giant series that consists of 491 patches. This is very trivial conversion. I think it is better to have a single patch to convert all files under drivers/tty/serial/, with the patch subject "serial:".
The difficulty there is determining where these subsystem spanning blocks should begin and end. That could not be done for instance with drivers/net. As I have suggested a few times, better still would be to have a mechanism for scripted patches applied possibly as single treewide patch. Likely applied only at an -rc1. The stated negatives to a treewide mechanism have been difficulty to backport to -stable. Perhaps a mechanism like git format-patch --stdout <treewide_commit_to_backport> | \ git apply --include=<specific_files> with some automated rewrite of the treewide patch subject then commit could help. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel