Thread (37 messages) 37 messages, 5 authors, 2020-03-17

Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case

From: Guenter Roeck <linux@roeck-us.net>
Date: 2020-03-09 18:19:32
Also in: linux-input, linux-pm, linux-rtc, linux-watchdog, lkml

On Mon, Mar 09, 2020 at 06:30:54PM +0100, Alexandre Belloni wrote:
On 09/03/2020 10:10:12-0700, Guenter Roeck wrote:
quoted
On Mon, Mar 09, 2020 at 05:47:05PM +0100, Alexandre Belloni wrote:
quoted
On 09/03/2020 06:27:06-0700, Guenter Roeck wrote:
quoted
On 3/9/20 4:06 AM, Alexandre Belloni wrote:
quoted
On 09/03/2020 08:38:14+0800, Anson Huang wrote:
quoted
Add stubs for those i.MX SCU APIs to make those modules depending
on IMX_SCU can pass build when COMPILE_TEST is enabled.

Signed-off-by: Anson Huang <redacted>
---
Changes since V2:
	- return error for stubs.
I'm not sure why you are sending v3 with the stubs as we determined that
2/7 is enough to compile all the drivers with COMPILE_TEST.
2/7 alone is not sufficient. With only 2/7, one can explicitly configure
IMX_SCU=n, COMPILE_TEST=y, and get lots of compile failures. Granted,
one should not do that, but 0day does (I don't know if that is the result
of RANDCONFIG), and I am not looking forward having to deal with the
fallout.
How would that be possible if the drivers all depend on IMX_SCU?
That dependency is being changed to IMX_SCU || COMPILE_TEST
as part of the series.
Yes, my point is that those patches should not be applied at all, only
2/7.
Ah, now I get it. Sorry, I missed that part. You are correct, that would
be sufficient, and I would very much prefer that approach.

Thanks,
Guenter

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help