Re: [RFC 2/3] mm/vma: Introduce VM_ACCESS_FLAGS
From: Vlastimil Babka <hidden>
Date: 2020-03-03 18:12:28
Also in:
linux-mm, linux-s390, linux-sh, linuxppc-dev, lkml
On 3/2/20 7:47 AM, Anshuman Khandual wrote:
There are many places where all basic VMA access flags (read, write, exec) are initialized or checked against as a group. One such example is during page fault. Existing vma_is_accessible() wrapper already creates the notion of VMA accessibility as a group access permissions. Hence lets just create VM_ACCESS_FLAGS (VM_READ|VM_WRITE|VM_EXEC) which will not only reduce code duplication but also extend the VMA accessibility concept in general. Cc: Russell King <linux@armlinux.org.uk> CC: Catalin Marinas <catalin.marinas@arm.com> CC: Mark Salter <redacted> Cc: Nick Hu <redacted> CC: Ley Foon Tan <redacted> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Heiko Carstens <redacted> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: Guan Xuetao <redacted> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Thomas Gleixner <redacted> Cc: Rob Springer <redacted> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-c6x-dev@linux-c6x.org Cc: nios2-dev@lists.rocketboards.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-s390@vger.kernel.org Cc: linux-sh@vger.kernel.org Cc: devel@driverdev.osuosl.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual <redacted>
Dunno. Such mask seems ok for testing flags, but it's a bit awkward when initializing flags, where it covers just one of many combinations that seem used. But no strong opinions, patch looks correct. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel