Thread (28 messages) 28 messages, 4 authors, 2020-04-27

Re: [PATCH v1 2/2] ARM: dts: Add Caninos Loucos Labrador

From: Manivannan Sadhasivam <hidden>
Date: 2020-02-29 10:42:15
Also in: linux-devicetree, lkml

Hi,

Thanks for the patch! Please find comments inline.

On Thu, Feb 27, 2020 at 05:15:57PM -0300, Matheus Castello wrote:
quoted hunk ↗ jump to hunk
Add Device Trees for Caninos Loucos Labrador SoM and base board.
Based on the work of Andreas Färber on Lemaker Guitar device tree.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
---
 arch/arm/boot/dts/Makefile                  |  3 +-
 arch/arm/boot/dts/owl-s500-labrador-bb.dts  | 33 +++++++++++++++++++++
 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++
 3 files changed, 56 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d6546d2676b9..acdf65ef3236 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -842,7 +842,8 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
 dtb-$(CONFIG_ARCH_ACTIONS) += \
 	owl-s500-cubieboard6.dtb \
 	owl-s500-guitar-bb-rev-b.dtb \
-	owl-s500-sparky.dtb
+	owl-s500-sparky.dtb \
+	owl-s500-labrador-bb.dtb
Please sort the entries alphabetically.
quoted hunk ↗ jump to hunk
 dtb-$(CONFIG_ARCH_PRIMA2) += \
 	prima2-evb.dtb
 dtb-$(CONFIG_ARCH_PXA) += \
diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
new file mode 100644
index 000000000000..1e821804da30
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
A title here would be helpful like how you added for the SoM below.
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+/dts-v1/;
+
+#include "owl-s500-labrador-v2.dtsi"
+#include <dt-bindings/leds/common.h>
Do we need this now?

Thanks,
Mani
quoted hunk ↗ jump to hunk
+
+/ {
+	compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500";
+	model = "Caninos Labrador Base Board M v1.0";
+
+	aliases {
+		serial3 = &uart3;
+	};
+
+	chosen {
+		stdout-path = "serial3:115200n8";
+	};
+
+	uart3_clk: uart3-clk {
+		compatible = "fixed-clock";
+		clock-frequency = <921600>;
+		#clock-cells = <0>;
+	};
+};
+
+&uart3 {
+	status = "okay";
+	clocks = <&uart3_clk>;
+};
diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
new file mode 100644
index 000000000000..ee079f02b5dd
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador SoM V2
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+#include "owl-s500.dtsi"
+
+/ {
+	compatible = "caninos,labrador", "actions,s500";
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x80000000>;
+	};
+};
+
+&timer {
+	clocks = <&hosc>;
+};
--
2.25.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help