-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: 2020年2月26日 1:58
To: Joakim Zhang <redacted>
Cc: mturquette@baylibre.com; sboyd@kernel.org; mark.rutland@arm.com;
shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
festevam@gmail.com; dl-linux-imx [off-list ref]; Anson Huang
[off-list ref]; Leonard Crestez [off-list ref];
Daniel Baluta [off-list ref]; Aisheng Dong
[off-list ref]; Peng Fan [off-list ref]; Andy Duan
[off-list ref]; linux-clk@vger.kernel.org;
devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] clk: imx8: Add SCU and LPCG clocks for I2C in CM40 SS

On Mon, Feb 17, 2020 at 11:19:16AM +0800, Joakim Zhang wrote:

quoted

Add SCU and LPCG clocks for I2C in CM40 SS.

Signed-off-by: Joakim Zhang <redacted>
---
 include/dt-bindings/clock/imx8-clock.h | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/imx8-clock.h

b/include/dt-bindings/clock/imx8-clock.h

quoted

index 673a8c662340..84a442be700f 100644

--- a/include/dt-bindings/clock/imx8-clock.h
+++ b/include/dt-bindings/clock/imx8-clock.h

@@ -131,7 +131,12 @@
 #define IMX_ADMA_PWM_CLK				188
 #define IMX_ADMA_LCD_CLK				189

-#define IMX_SCU_CLK_END					190
+/* CM40 SS */
+#define IMX_CM40_IPG_CLK				200
+#define IMX_CM40_I2C_CLK				205
+
+#define IMX_SCU_CLK_END					220

Why are you skipping numbers?

Hi Rob,

I found that there is a gap in SCU clock between subsystem, some numbers could be reserved for devices which may be added into this subsystem in the future. 

Best Regards,
Joakim Zhang

quoted

+

 /* LPCG clocks */

@@ -290,4 +295,10 @@

 #define IMX_ADMA_LPCG_CLK_END				45

+/* CM40 SS LPCG */
+#define IMX_CM40_LPCG_I2C_IPG_CLK			0
+#define IMX_CM40_LPCG_I2C_CLK				1
+
+#define IMX_CM40_LPCG_CLK_END				2
+
 #endif /* __DT_BINDINGS_CLOCK_IMX_H */
--

2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel