Thread (15 messages) 15 messages, 7 authors, 2020-04-02

Re: [PATCH 16/18] clocksource: Replace setup_irq() by request_irq()

From: Linus Walleij <hidden>
Date: 2020-02-20 14:48:44
Also in: linux-amlogic, linux-samsung-soc, lkml

On Wed, Feb 12, 2020 at 9:05 AM afzal mohammed [off-list ref] wrote:
request_irq() is preferred over setup_irq(). Existing callers of
setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while
memory allocators are ready by 'mm_init()'.

Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.

Hence replace setup_irq() by request_irq().

Seldom remove_irq() usage has been observed coupled with setup_irq(),
wherever that has been found, it too has been replaced by free_irq().

[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos

Signed-off-by: afzal mohammed <redacted>
This makes the kernel a better place.
Acked-by: Linus Walleij <redacted>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help