Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk

From
Robin Murphy <robin.murphy@arm.com>
Date
2020-02-18 17:32:33
Also in
kvm, linux-clk, linux-devicetree, linux-edac, linux-ide, linux-iommu, linux-pm, lkml, netdev
Reply to
Will Deacon, 2020-02-18
On 18/02/2020 5:20 pm, Will Deacon wrote:
On Tue, Feb 18, 2020 at 11:13:16AM -0600, Rob Herring wrote:
quoted
Cc: Will Deacon <will@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: <redacted>
Signed-off-by: Rob Herring <robh@kernel.org>
---
Do not apply yet.
Pleeeeease? ;)
quoted
  drivers/iommu/arm-smmu-impl.c | 43 -----------------------------------
Presumably we also want to remove the definition of the option from binding too.
quoted
  1 file changed, 43 deletions(-)
Yes, I'm happy to get rid of this. Sadly, I don't think we can remove
anything from 'struct arm_smmu_impl' because most implementations fall
just short of perfect.
Right, this served as the prototype for register access hooks, but we have at least one other known user for those.
Anyway, let me know when I can push the button and I'll queue this in
the arm-smmu tree.
FWIW the quirk has proven useful in other circumstances too, but I imagine if we ever have to prototype an integration on VExpress-CA9 again, reverting this patch will hardly be the most unpleasant part :)

Robin.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (36 messages) 36 messages, 13 authors, last reply 2020-02-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help