Thread (25 messages) 25 messages, 4 authors, 2020-02-18

Re: [PATCH 19/19] arm64: vdso32: Enable Clang Compilation

From: Ard Biesheuvel <hidden>
Date: 2020-02-17 22:40:07
Also in: linux-arch, linux-mips, lkml

On Mon, 17 Feb 2020 at 17:46, Will Deacon [off-list ref] wrote:
On Mon, Feb 17, 2020 at 12:26:16PM +0000, Vincenzo Frascino wrote:
quoted
On 13/02/2020 18:44, Nathan Chancellor wrote:
quoted
On Thu, Feb 13, 2020 at 04:16:14PM +0000, Vincenzo Frascino wrote:
quoted
Enable Clang Compilation for the vdso32 library.
[...]
quoted
quoted
+LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc
Well this is unfortunate :/

It looks like adding the --target flag to VDSO_LDFLAGS allows
clang to link the vDSO just fine although it does warn that -nostdinc
is unused:

clang-11: warning: argument unused during compilation: '-nostdinc'
[-Wunused-command-line-argument]
This is why ended up in this "unfortunate" situation :) I wanted to avoid the
warning.
quoted
It would be nice if the logic of commit fe00e50b2db8 ("ARM: 8858/1:
vdso: use $(LD) instead of $(CC) to link VDSO") could be adopted here
but I get that this Makefile is its own beast :) at the very least, I
think that the --target flag should be added to VDSO_LDFLAGS so that gcc
is not a requirement for this but I am curious if you tried that already
and noticed any issues with it.
--target is my preferred way as well, I can try to play another little bit with
the flags and see what I can come up with in the next version.
Yes, please. I'd even prefer the warning rather than silently assuming that
a cross gcc is kicking around on the path.
Doesn't Clang have -Qunused-arguments for that?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help