Re: [PATCH v3 5/7] drm/panfrost: Add support for multiple power domains

On Mon, Jan 20, 2020 at 10:53 PM Steven Price [off-list ref] wrote:

On 14/01/2020 07:16, Nicolas Boichat wrote:
[snip]

quoted

+     err = panfrost_pm_domain_init(pfdev);
+     if (err) {
+             dev_err(pfdev->dev, "pm_domain init failed %d\n", err);

No need for this print - panfrost_pm_domain_init() will output a (more
appropriate) error message on failure.

Dropped.

quoted

+             goto err_out2;
+     }
+

[snip]

quoted

@@ -196,6 +274,7 @@ void panfrost_device_fini(struct panfrost_device *pfdev)
      panfrost_mmu_fini(pfdev);
      panfrost_gpu_fini(pfdev);
      panfrost_reset_fini(pfdev);
+     panfrost_pm_domain_fini(pfdev);

NIT: The reverse of the construction order would be to do this before
panfrost_reset_fini().

Oh right, fixed.

Thanks.

[snip]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel