RE: [PATCH 1/2] firmware: arm_scmi: mailbox: share shmem for protocols
From: Peng Fan <peng.fan@nxp.com>
Date: 2020-02-07 02:08:11
Also in:
lkml
Subject: Re: [PATCH 1/2] firmware: arm_scmi: mailbox: share shmem for protocols On Thu, Feb 06, 2020 at 08:57:25PM +0800, peng.fan@nxp.com wrote:quoted
From: Peng Fan <peng.fan@nxp.com> When shmem property of protocol is not specificed, let it use its parent's shmem property.
+arm list
Why do you even need this ? If shmem property of protocol is not specified then why is the mailbox property ? Either you need both or none. I don't see the point of this patch. I am interested to know how are you even hitting this case.
Without this patch, I need add shmem property in each protocol node. With this patch, I only need to add shmem property in scmi node. In mailbox_chan_setup, cdev is protocol device, input parameter device is the parent, saying scmi device.
If you don't have mailbox property, then chan_available is false and hence we don't call chan_setup.
chan_avilable only parse mbox properties, not shmem. Regards, Peng.
-- Regards, Sudeep
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel