Re: [PATCH v8 3/3] arm64: Use v8.5-RNG entropy for KASLR seed

On Wed, Jan 08, 2020 at 06:38:48PM +0100, Ard Biesheuvel wrote:

On Tue, 7 Jan 2020 at 19:38, Mark Brown [off-list ref] wrote:

quoted

+               if ((ftr >> ID_AA64ISAR0_RNDR_SHIFT) & 0xf) {
+                       if (__arm64_rndr(&raw))
+                               seed += raw;

Using addition rather than xor to combine seeds is slightly
unidiomatic, so if you are doing this for a specific reason, it would
be good to mention it.

No particular reason.