Thread (11 messages) 11 messages, 4 authors, 2020-01-16

Re: [PATCH 1/3] dt-bindings: timer: Add STM32 Low Power Timer bindings

From: Rob Herring <robh@kernel.org>
Date: 2020-01-15 19:00:42
Also in: linux-devicetree

On Wed, Jan 15, 2020 at 8:46 AM Benjamin Gaignard
[off-list ref] wrote:
Le mer. 15 janv. 2020 à 15:35, Rob Herring [off-list ref] a écrit :
quoted
On Thu, Jan 09, 2020 at 03:53:31PM +0100, Benjamin Gaignard wrote:
quoted
Document STM32 Low Power bindings.

Signed-off-by: Benjamin Gaignard <redacted>
---
 .../bindings/timer/st,stm32-lp-timer.yaml          | 44 ++++++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml
diff --git a/Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml b/Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml
new file mode 100644
index 000000000000..ca040b96dc47
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml
Use the compatible for the filename.
it will be in v2
quoted
quoted
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/st,stm32-lp-timer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STM32 Low Power 16 bits timers bindings
+
+maintainers:
+  - Benjamin Gaignard <benjamin.gaignard@st.com>
+
+properties:
+  compatible:
+    const: st,stm32-lptimer-clkevent
'clkevent' is a h/w name? Seems redundant and abusing compatible to
bind to a specific Linux driver.
No but st,stm32-lptimer compatible is already used for another driver
The hardware block can implement multiple features but not all at the same time
so I try to distinguish them with the compatible.
In this particular case I would like tag it as a clock event driver.
That's a Linux specific thing which we've said no to for 10 years.

Is "Not at the same time" a chip design time configuration or run-time
config. If the latter, why do you want to use a particular instance
over another one for clock event? There has to be some h/w difference.
Describe the difference and then use that to grab the device to use
for a clockevent. I'm fine if you omit the pwm node and then use that
to decide which instance to use.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help