Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
From: Brendan Higgins <hidden>
Date: 2020-01-27 09:46:39
Also in:
linux-aspeed, linux-um, lkml
On Wed, Dec 11, 2019 at 4:30 PM Brendan Higgins [off-list ref] wrote:
On Wed, Dec 11, 2019 at 4:12 PM Joel Stanley [off-list ref] wrote:quoted
On Wed, 11 Dec 2019 at 19:28, Brendan Higgins [off-list ref] wrote:quoted
Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error: ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe': drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource' Fix the build error by adding the unspecified dependency. Reported-by: Brendan Higgins <redacted> Signed-off-by: Brendan Higgins <redacted>Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in order to build some ARM drivers under UM. Do you have plans to fix that too?The only broken configs I found for UML are all listed on the cover letter of this patch. I think fixing COMPILE_TEST on UM could be worthwhile. Did you see any brokenness other than what I mentioned on the cover letter?quoted
Do you want to get this in a fix for 5.5?Preferably, yes.quoted
Acked-by: Joel Stanley <joel@jms.id.au>
Hey, I know I owe you a reply about debugging your kunitconfig (I'll try to get to that this week); nevertheless, it looks like this patch didn't make it into 5.5. Can you make sure it gets into 5.6? It shouldn't depend on anything else. Cheers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel