Thread (28 messages) 28 messages, 10 authors, 2020-01-27

Re: [PATCH v4 7/9] parisc/perf: open access for CAP_SYS_PERFMON privileged process

From: Helge Deller <deller@gmx.de>
Date: 2020-01-27 08:53:33
Also in: bpf, intel-gfx, linux-perf-users, linux-security-module, linuxppc-dev, lkml, selinux

On 18.12.19 10:29, Alexey Budankov wrote:
Open access to monitoring for CAP_SYS_PERFMON privileged processes.
For backward compatibility reasons access to the monitoring remains open
for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure
monitoring is discouraged with respect to CAP_SYS_PERFMON capability.

Signed-off-by: Alexey Budankov <redacted>
Acked-by: Helge Deller <deller@gmx.de>
quoted hunk ↗ jump to hunk
---
 arch/parisc/kernel/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/parisc/kernel/perf.c b/arch/parisc/kernel/perf.c
index 676683641d00..c4208d027794 100644
--- a/arch/parisc/kernel/perf.c
+++ b/arch/parisc/kernel/perf.c
@@ -300,7 +300,7 @@ static ssize_t perf_write(struct file *file, const char __user *buf,
 	else
 		return -EFAULT;

-	if (!capable(CAP_SYS_ADMIN))
+	if (!perfmon_capable())
 		return -EACCES;

 	if (count != sizeof(uint32_t))

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help