On 20/01/2020 15:53, Dietmar Eggemann wrote:

On 16/01/2020 16:20, lukasz.luba@arm.com wrote:

quoted

From: Lukasz Luba <lukasz.luba@arm.com>

[...]

quoted

+enum em_type {
+	EM_SIMPLE,
+	EM_CPU,
+};

s/EM_SIMPLE/EM_DEV ?

Right now I only see energy models and _one_ specific type (the CPU EM).
So a tag 'is a CPU EM' would suffice. No need for EM_SIMPE ...

Wait, you even have

struct em_device {
        struct em_perf_domain *em_pd;
        struct device *dev;
        ...
}

static bool _is_cpu_device(struct device *dev)

Shouldn't this be enough to distinguish between EM and special CPU EM
under the API? Even when required to use container_of() to get from
em_perf_domain to device.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel