Thread (4 messages) 4 messages, 2 authors, 2020-01-17

Re: [PATCH] tty: serial: amba-pl011: added RS485 support

From: Ivan Sistik - 3K Solutions, s. r. o. <hidden>
Date: 2020-01-17 00:32:07
Also in: linux-serial, lkml

On 7. 1. 2020 at 8:27 Greg Kroah-Hartman wrote:
quoted
+config SERIAL_AMBA_PL011_SOFT_RS485
+	bool "RS485 software direction switching for ARM AMBA PL011 serial"
+	depends on SERIAL_AMBA_PL011=y
Why "=y" here?  Shouldn't this just read:
	depends on SERIAL_AMBA_PL011?
quoted
+	select SERIAL_CORE
Is this needed?  SERIAL_AMBA_PL011 already selects this.
I am not sure. I found this few lines above:
config SERIAL_AMBA_PL010_CONSOLE
	bool "Support for console on AMBA serial port"
	depends on SERIAL_AMBA_PL010=y
	select SERIAL_CORE_CONSOLE
and modified it for my purpose.


Thanks,

Ivan


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help