Re: [PATCH V11 1/5] mm/hotplug: Introduce arch callback validating the hot remove range
From: Anshuman Khandual <hidden>
Date: 2020-01-13 04:05:09
Also in:
linux-mm, lkml, oe-kbuild-all
On 01/11/2020 07:41 PM, kbuild test robot wrote:
mm/memory_hotplug.c: In function 'check_hotremove_memory_range':quoted
quoted
mm/memory_hotplug.c:1027:7: error: implicit declaration of function 'arch_memory_removable'; did you mean 'add_memory_resource'? [-Werror=implicit-function-declaration]rc = arch_memory_removable(start, size); ^~~~~~~~~~~~~~~~~~~~~ add_memory_resource At top level: mm/memory_hotplug.c:1017:12: warning: 'check_hotremove_memory_range' defined but not used [-Wunused-function] static int check_hotremove_memory_range(u64 start, u64 size) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +1027 mm/memory_hotplug.c 1016 1017 static int check_hotremove_memory_range(u64 start, u64 size) 1018 { 1019 int rc; 1020 1021 BUG_ON(check_hotplug_memory_range(start, size)); 1022 1023 /* 1024 * First check if the platform is willing to have this 1025 * memory range removed else just abort. 1026 */quoted
1027 rc = arch_memory_removable(start, size);1028 if (!rc) 1029 return -EINVAL; 1030 1031 return 0; 1032 } 1033
Both the build failures reported here could be solved by moving check_hotremove_memory_range() inside CONFIG_MEMORY_HOTREMOVE wrappers, will fix it. - Anshuman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel