Re: [PATCH] staging: vc04_service: remove unused header include path
From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2020-01-10 13:48:32
Also in:
lkml
On Fri, Jan 10, 2020 at 9:24 PM Greg Kroah-Hartman [off-list ref] wrote:
On Sun, Jan 05, 2020 at 01:28:29AM +0900, Masahiro Yamada wrote:quoted
I can build drivers/staging/vc04_services without this. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- drivers/staging/vc04_services/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/vc04_services/Makefile b/drivers/staging/vc04_services/Makefile index afe43fa5a6d7..54d9e2f31916 100644 --- a/drivers/staging/vc04_services/Makefile +++ b/drivers/staging/vc04_services/Makefile@@ -13,5 +13,5 @@ vchiq-objs := \ obj-$(CONFIG_SND_BCM2835) += bcm2835-audio/ obj-$(CONFIG_VIDEO_BCM2835) += bcm2835-camera/ -ccflags-y += -Idrivers/staging/vc04_services -D__VCCOREVER__=0x04000000 +ccflags-y += -D__VCCOREVER__=0x04000000 --This patch breaks the build for me: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:6:10: fatal error: interface/vchi/vchi.h: No such file or directory 6 | #include "interface/vchi/vchi.h" | ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. So maybe you did't select all of the modules to build? Sorry, I can't take this as-is :( greg k-h
Sorry, I compile-tested it with O= option. I should have tested it with/without O= for this kind of patch. I will fix up some relative paths. -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel