Thread (11 messages) 11 messages, 2 authors, 2020-01-09

Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

From: Shawn Guo <shawnguo@kernel.org>
Date: 2020-01-09 10:38:47
Also in: linux-devicetree, lkml

On Thu, Jan 09, 2020 at 09:25:35AM +0000, Anson Huang wrote:
Hi, Shawn
quoted
Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
power supply assignment

On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
quoted
Hi, Shawn
quoted
Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
power supply assignment

On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
quoted
The vdd3p0's input should be from external USB VBUS directly, NOT
Shouldn't USB VBUS usually be 5V?  It doesn't seem to match 3.0V
which is suggested by vdd3p0 name.
quoted
PMIC's sw2, so remove the power supply assignment for vdd3p0.

Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign
corresponding power supply for LDOs")
Is it only a description correcting or is it fixing a real problem?
I'm trying to understand it is a 5.5-rc material or can be applied for 5.6.
It is fixing a real problem about USB LDO voltage, that is why we noticed
this issue.

Okay, please describe the problem a little bit in the commit log.  Also squash
the series into one patch, which is easier to be merged into -rc as a fix.
OK, will send a new patch with squashing them together, but will NOT have the fix tag,
is it OK? As the fix tag are different for each patch.
Good point.  I just applied series (as separate patch) to make the
stable kernel back port easier.  Patch #5 is fixing a commit that hasn't
landed on mainline, so I drop the fix tag, as the commit ID is not
stable.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help