Re: [PATCH v2 2/4] media: cedrus: hevc: Add support for scaling matrix

On 1/7/20 6:10 PM, Jernej Škrabec wrote:

Hi!

Dne torek, 07. januar 2020 ob 16:01:16 CET je Hans Verkuil napisal(a):

quoted

On 12/13/19 5:04 PM, Jernej Skrabec wrote:

quoted

HEVC frames may use scaling list feature. Add support for it.

Signed-off-by: Jernej Skrabec <redacted>
---

 drivers/staging/media/sunxi/cedrus/cedrus.c   |  7 ++
 drivers/staging/media/sunxi/cedrus/cedrus.h   |  1 +
 .../staging/media/sunxi/cedrus/cedrus_dec.c   |  2 +
 .../staging/media/sunxi/cedrus/cedrus_h265.c  | 70 ++++++++++++++++++-
 .../staging/media/sunxi/cedrus/cedrus_regs.h  |  2 +
 5 files changed, 81 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c

b/drivers/staging/media/sunxi/cedrus/cedrus.c index
c6ddd46eff82..bf68bc6b20c8 100644

--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c

@@ -116,6 +116,13 @@ static const struct cedrus_control cedrus_controls[]

= {> 
 		.codec		= CEDRUS_CODEC_H265,
 		.required	= true,
 	
 	},

+	{
+		.cfg = {
+			.id	= 

V4L2_CID_MPEG_VIDEO_HEVC_SCALING_MATRIX,

quoted

quoted

+		},
+		.codec		= CEDRUS_CODEC_H265,
+		.required	= true,

Should this be true? This means that existing applications are now
suddenly required to always pass the scaling matrix for every buffer.

Especially since the commit log says: 'HEVC frames *may* use scaling list
feature', indicating that this is an optional feature.

True. Can you fix this when applying if this is the only issue?

I'll do that.

Regards,

	Hans

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel