Re: [PATCH 2/2] dmaengine: pl330: Convert to the *_late and *_early system sleep callbacks
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: 2019-12-06 11:46:37
Also in:
dmaengine, linux-samsung-soc
Hi, On 05.12.2019 15:37, Ulf Hansson wrote:
It has turned out that it's in general a good idea for dmaengines to allow DMA requests during the entire dpm_suspend() phase. Therefore, convert the pl330 driver into using SET_LATE_SYSTEM_SLEEP_PM_OPS. Signed-off-by: Ulf Hansson <redacted>
Works fine on various Samsung Exynos boards I have for tests. Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
quoted hunk ↗ jump to hunk
--- drivers/dma/pl330.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 8e01da157518..88b884cbb7c1 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c@@ -2981,7 +2981,9 @@ static int __maybe_unused pl330_resume(struct device *dev) return ret; } -static SIMPLE_DEV_PM_OPS(pl330_pm, pl330_suspend, pl330_resume); +static const struct dev_pm_ops pl330_pm = { + SET_LATE_SYSTEM_SLEEP_PM_OPS(pl330_suspend, pl330_resume) +}; static int pl330_probe(struct amba_device *adev, const struct amba_id *id)
Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel