Thread (58 messages) 58 messages, 7 authors, 2020-02-26

Re: [RFC 22/25] leds: tm1826: Add combined glyph support

From: Pavel Machek <hidden>
Date: 2019-12-21 21:04:15
Also in: linux-leds, lkml

Hi!
quoted
quoted
Allow to squeeze the text "HEllO" into a 4-digit display,
as seen on MeLE V9 TV box.

Enable this combining mode only if the text would overflow.
"HEll,nO"!

:-)

Ok, it is kind of cool, but... Can you take a look at
drivers/auxdisplay/charlcd.c ? It seems to support some kind of text
displays...
Why don't you look at it before making such a suggestion? ;) It is in no way
useful, as I pointed out in my cover letter. The only thing related today,
as Geert pointed out, is in the input subsystem.
Okay, so maybe we should get

AUXILIARY DISPLAY DRIVERS
M:      Miguel Ojeda Sandonis [off-list ref]

on the Cc: list? What you really have is a display, not a bunch of LEDs.
If you don't want this in leds, you'll have to help make leds subsystem more
useful to external users - the latest function refactoring has been anything
but helpful here, as you've seen with the indicators, and we're completely
lacking any indexing or bulk operations on the LED controller level, since
you treat each LED as a standalone device. That's precisely why this code is
here in leds although - as I pointed out - it shouldn't belong here.
Well, your introduction mail was kind of long :-).

If someone wants to do heartbeat on

 --
|  | <- this segment
 --
|  |
 --

they are probably crazy. We may not want to support that. What about
doing it as auxdisplay driver, and then exporting the indicators
around that as LEDs?

Having USB activity trigger on 'USB' icon makes sense, on the other
hand. That would still be supported.

Hmm?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help