Re: [v5, PATCH 2/5] dt-bindings: devfreq: add compatible for mt8183 cci devfreq
From: Chanwoo Choi <cw00.choi@samsung.com>
Date: 2019-12-17 02:32:16
Also in:
linux-devicetree, linux-mediatek, linux-pm, lkml
Hi, On 11/26/19 8:50 PM, Andrew-sh.Cheng wrote:
From: "Andrew-sh.Cheng" <redacted> This adds dt-binding documentation of cci devfreq for Mediatek MT8183 SoC platform. Signed-off-by: Andrew-sh.Cheng <redacted> --- .../bindings/devfreq/mt8183-cci-devfreq.txt | 20 ++++++++++++++++++++
mt8183-cci.txt is better without 'devfreq' word. I recommend to make the binding document with yaml. You can refer to the example[1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-next&id=6ad0b4fb960c3bc32034d8f3ec7609c8bcb8d9a4
quoted hunk ↗ jump to hunk
1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txtdiff --git a/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt new file mode 100644 index 000000000000..a65a70bb9f09 --- /dev/null +++ b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt@@ -0,0 +1,20 @@ +* Mediatek Cache Coherent Interconnect(CCI) frequency device
recommend to add the more detailed description of what is the role of this driver.
quoted hunk ↗ jump to hunk
+ +Required properties: +- compatible: should contain "mediatek,mt8183-cci" for frequency scaling of CCI +- clocks: for frequency scaling of CCI +- clock-names: for frequency scaling of CCI driver to reference
quoted hunk ↗ jump to hunk
+- regulator: for voltage scaling of CCI +- operating-points-v2: for frequency scaling of CCI opp table + +Example: + cci: cci { + compatible = "mediatek,mt8183-cci"; + clocks = <&apmixedsys CLK_APMIXED_CCIPLL>; + clock-names = "cci_clock";
Recommend to use 'cci' without '_clock' because we can know that it's clock name event if '_clock'.
+ operating-points-v2 = <&cci_opp>;
+ };
+
+ &cci {
+ proc-supply = <&mt6358_vproc12_reg>;
+ };
\ No newline at end of file-- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel