Re: [PATCH 03/14] media: sun4i-csi: Fix data sampling polarity handling
From: Maxime Ripard <mripard@kernel.org>
Date: 2019-12-16 13:36:09
Also in:
linux-devicetree, linux-media, lkml
On Mon, Dec 16, 2019 at 12:59:13AM +0800, Chen-Yu Tsai wrote:
From: Chen-Yu Tsai <redacted>
The CLK_POL field specifies whether data is sampled on the falling or
rising edge of PCLK, not whether the data lines are active high or low.
Evidence of this can be found in the timing diagram labeled "horizontal
size setting and pixel clock timing".
Fix the setting by checking the correct flag, V4L2_MBUS_PCLK_SAMPLE_RISING.
While at it, reorder the three polarity flag checks so HSYNC and VSYNC
are grouped together.
Fixes: 577bbf23b758 ("media: sunxi: Add A10 CSI driver")
Signed-off-by: Chen-Yu Tsai <redacted>Acked-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime