Re: [PATCH v4 1/6] dt-bindings: clock: meson: add A1 PLL clock controller bindings
From: Maxime Ripard <hidden>
Date: 2019-12-13 10:39:03
Also in:
linux-amlogic, linux-clk, linux-devicetree, lkml
Hi, On Fri, Dec 06, 2019 at 03:40:47PM +0800, Jian Hu wrote:
quoted hunk ↗ jump to hunk
Add the documentation to support Amlogic A1 PLL clock driver, and add A1 PLL clock controller bindings. Signed-off-by: Jian Hu <redacted> --- .../bindings/clock/amlogic,a1-pll-clkc.yaml | 59 +++++++++++++++++++ include/dt-bindings/clock/a1-pll-clkc.h | 16 +++++ 2 files changed, 75 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml create mode 100644 include/dt-bindings/clock/a1-pll-clkc.hdiff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml new file mode 100644 index 000000000000..7feeef5abf1b --- /dev/null +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml@@ -0,0 +1,59 @@ +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ +/* + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. + */ +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic Meson A/C serials PLL Clock Control Unit Device Tree Bindings + +maintainers: + - Neil Armstrong <narmstrong@baylibre.com> + - Jerome Brunet <jbrunet@baylibre.com> + - Jian Hu <jian.hu@jian.hu.com> + +properties: + compatible: + - enum: + - amlogic,a1-pll-clkc
I'm not sure this works, compatible shouldn't contain a list. You can write this like: compatible: const: amlogic,a1-pll-clkc
+ "#clock-cells": + const: 1 + + reg: + maxItems: 1 + +clocks: + minItems: 2 + maxItems: 2
This is redundant, it will be added automatically by the tools ...
+ items: + - description: Input xtal_fixpll + - description: Input xtal_hifipll
... When you have a list of items :)
+ +clock-names: + minItems: 2 + maxItems: 2 + items: + - const: xtal_fixpll + - const: xtal_hifipll
Same story here Maxime