[PATCH v16 00/25] Generic page walk and ptdump · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 01/25] mm: Add generic p?d_leaf() macros · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 02/25] arc: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 03/25] arm: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 04/25] arm64: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 05/25] mips: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 06/25] powerpc: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-06
Re: [PATCH v16 06/25] powerpc: mm: Add p?d_leaf() definitions · Michael Ellerman <mpe@ellerman.id.au> · 2019-12-09
Re: [PATCH v16 06/25] powerpc: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-09
[PATCH v16 08/25] s390: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 09/25] sparc: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 10/25] x86: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 11/25] mm: pagewalk: Add p4d_entry() and pgd_entry() · Steven Price <steven.price@arm.com> · 2019-12-06
Re: [PATCH v16 11/25] mm: pagewalk: Add p4d_entry() and pgd_entry() · Thomas Hellström (VMware) <hidden> · 2019-12-12
Re: [PATCH v16 11/25] mm: pagewalk: Add p4d_entry() and pgd_entry() · Thomas Hellström (VMware) <hidden> · 2019-12-12
Re: [PATCH v16 11/25] mm: pagewalk: Add p4d_entry() and pgd_entry() · Steven Price <steven.price@arm.com> · 2019-12-12
Re: [PATCH v16 11/25] mm: pagewalk: Add p4d_entry() and pgd_entry() · Thomas Hellström (VMware) <hidden> · 2019-12-12
Re: [PATCH v16 11/25] mm: pagewalk: Add p4d_entry() and pgd_entry() · Steven Price <steven.price@arm.com> · 2019-12-12
[PATCH v16 12/25] mm: pagewalk: Allow walking without vma · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 14/25] mm: pagewalk: fix termination condition in walk_pte_range() · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 15/25] mm: pagewalk: Add test_p?d callbacks · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 17/25] x86: mm: Point to struct seq_file from struct pg_state · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 19/25] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 20/25] x86: mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 21/25] mm: Add generic ptdump · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 23/25] arm64: mm: Convert mm/dump.c to use walk_page_range() · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 24/25] arm64: mm: Display non-present entries in ptdump · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 25/25] mm: ptdump: Reduce level numbers by 1 in note_page() · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 22/25] x86: mm: Convert dump_pagetables to use walk_page_range · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 13/25] mm: pagewalk: Don't lock PTEs for walk_page_range_novma() · Steven Price <steven.price@arm.com> · 2019-12-06
Re: [PATCH v16 13/25] mm: pagewalk: Don't lock PTEs for walk_page_range_novma() · kbuild test robot <hidden> · 2019-12-10
Re: [PATCH v16 13/25] mm: pagewalk: Don't lock PTEs for walk_page_range_novma() · Steven Price <steven.price@arm.com> · 2019-12-11
Re: [PATCH v16 13/25] mm: pagewalk: Don't lock PTEs for walk_page_range_novma() · Luc Van Oostenryck <hidden> · 2019-12-11
Re: [PATCH v16 13/25] mm: pagewalk: Don't lock PTEs for walk_page_range_novma() · Qian Cai <hidden> · 2019-12-11
[PATCH v16 18/25] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 16/25] mm: pagewalk: Add 'depth' parameter to pte_hole · Steven Price <steven.price@arm.com> · 2019-12-06
[PATCH v16 07/25] riscv: mm: Add p?d_leaf() definitions · Steven Price <steven.price@arm.com> · 2019-12-06

Re: [PATCH v16 13/25] mm: pagewalk: Don't lock PTEs for walk_page_range_novma()

From: Luc Van Oostenryck <hidden>
Date: 2019-12-11 17:12:58
Also in: linux-mm, lkml

On Wed, Dec 11, 2019 at 03:54:06PM +0000, Steven Price wrote:

On 10/12/2019 11:23, kbuild test robot wrote:

quoted

include/linux/spinlock.h:378:9: sparse: sparse: context imbalance in 'walk_pte_range' - unexpected unlock

I believe this is a false positive (although the trace here is useless).
This patch adds a conditional lock/unlock:

pte = walk->no_vma ? pte_offset_map(pmd, addr) :
		     pte_offset_map_lock(walk->mm, pmd, addr, &ptl);
...
if (!walk->no_vma)
	spin_unlock(ptl);
pte_unmap(pte);

I'm not sure how to match sparse happy about that. Is the only option to
have two versions of the walk_pte_range() function? One which takes the
lock and one which doesn't.

Yes.

-- Luc

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help