Thread (59 messages) 59 messages, 5 authors, 2021-01-19

RE: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of IS_ERR_VALUE()

From: Leo Li <hidden>
Date: 2019-12-02 22:52:04
Also in: linuxppc-dev, lkml, netdev

-----Original Message-----
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Sent: Thursday, November 28, 2019 8:56 AM
To: Qiang Zhao <qiang.zhao@nxp.com>; Leo Li <redacted>;
Christophe Leroy [off-list ref]
Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; Scott Wood [off-list ref]; Timur Tabi
[off-list ref]; Rasmus Villemoes [off-list ref];
netdev@vger.kernel.org
Subject: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of
IS_ERR_VALUE()
Hi David,

Would you help to review patch 44-47 in the series?  If it is fine with you, I can take these 4 patches with the whole series though soc tree to enable the QE drivers on ARM and PPC64 with your ACK.

Thanks,
Leo
When building this on a 64-bit platform gcc rightly warns that the error
checking is broken (-ENOMEM stored in an u32 does not compare greater
than (unsigned long)-MAX_ERRNO). Instead, now that
qe_muram_alloc() returns s32, use that type to store the return value and
use standard kernel style "ret < 0".

Reviewed-by: Timur Tabi <timur@kernel.org>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help