Re: [PATCH] irqchip/gic-v3-its: Reference toits_invall_cmd descriptor when building INVALL
From: Marc Zyngier <maz@kernel.org>
Date: 2019-12-02 10:00:14
Also in:
lkml
Hi Zenghui, On 2019-12-02 07:10, Zenghui Yu wrote:
quoted hunk ↗ jump to hunk
It looks like an obvious mistake to use its_mapc_cmd descriptor when building the INVALL command block. It so far worked by luck because both its_mapc_cmd.col and its_invall_cmd.col sit at the same offset of the ITS command descriptor, but we should not rely on it. Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/irqchip/irq-gic-v3-its.cb/drivers/irqchip/irq-gic-v3-its.c index c52cc8d6d6b8..b3fec78b2226 100644--- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c@@ -598,7 +598,7 @@ static struct its_collection*its_build_invall_cmd(struct its_node *its, struct its_cmd_desc *desc) { its_encode_cmd(cmd, GITS_CMD_INVALL); - its_encode_collection(cmd, desc->its_mapc_cmd.col->col_id); + its_encode_collection(cmd, desc->its_invall_cmd.col->col_id); its_fixup_cmd(cmd);
Yup, well spotted. Thankfully, there is no impact due to the two
structures having similar layouts, but that definitely needs
fixing.
I'll queue this for post -rc1.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel