On Thu, Nov 07, 2019 at 12:01:10PM +0000, Suzuki K Poulose wrote:
quoted
+ if ((ftr >> ID_AA64MMFR2_E0PD_SHIFT) & 0xf)
nit: You may use the existing helper :
cpuid_feature_extract_unsigned_field(ftr, ID_AA64MMFR2_E0PD_SHIFT)
Actually, the name of the helper is so verbose that it's makes
formatting things into 80 columns hard, you end up with something like:
ftr = read_sysreg_s(SYS_ID_AA64MMFR2_EL1);
if (cpuid_feature_extract_unsigned_field(ftr,
ID_AA64MMFR2_E0PD_SHIFT))
which is awkward.