Thread (13 messages) 13 messages, 2 authors, 2019-11-08

Re: [PATCH v7 3/4] arm64: Don't use KPTI where we have E0PD

From: Mark Brown <broonie@kernel.org>
Date: 2019-11-07 14:48:16

On Thu, Nov 07, 2019 at 12:01:10PM +0000, Suzuki K Poulose wrote:
quoted
+		if ((ftr >> ID_AA64MMFR2_E0PD_SHIFT) & 0xf)
nit: You may use the existing helper :
	cpuid_feature_extract_unsigned_field(ftr, ID_AA64MMFR2_E0PD_SHIFT)
Actually, the name of the helper is so verbose that it's makes
formatting things into 80 columns hard, you end up with something like:

		ftr = read_sysreg_s(SYS_ID_AA64MMFR2_EL1);
		if (cpuid_feature_extract_unsigned_field(ftr,
					ID_AA64MMFR2_E0PD_SHIFT))

which is awkward.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help