Thread (44 messages) 44 messages, 7 authors, 2019-11-12

Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2019-11-06 18:16:52
Also in: linux-alpha, linux-arch, linux-m68k, linux-mips, linux-riscv, linux-s390, linux-sh, lkml, sparclinux

Hi Palmer,

On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt [off-list ref] wrote:
It looks like the difference in prototype between the architectures is between

    void __iomem *ioremap(resource_size_t, size_t)
    void __iomem *ioremap(phys_addr_t, size_t)
    void __iomem *ioremap(phys_addr_t, unsigned long)
    void __iomem *ioremap(unsigned long, unsigned long)

shouldn't they all just be that first one?  In other words, wouldn't it be
better to always provide the generic ioremap prototype and unify the ports
instead?
Agreed. But I'd go for the second one.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help