RE: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

On 01/11/2019 23:31, Rasmus Villemoes wrote :

-----Original Message-----
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Sent: 2019年11月4日 16:38
To: Leo Li <redacted>; Christophe Leroy <redacted>;
Qiang Zhao [off-list ref]
Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; Scott Wood [off-list ref];
netdev@vger.kernel.org
Subject: Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend
on PPC32

On 01/11/2019 23.31, Leo Li wrote:

quoted

quoted

-----Original Message-----
From: Christophe Leroy <redacted>
Sent: Friday, November 1, 2019 11:30 AM
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>; Qiang Zhao
[off-list ref]; Leo Li [off-list ref]
Cc: linuxppc-dev@lists.ozlabs.org;
linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; Scott Wood [off-list ref];
netdev@vger.kernel.org
Subject: Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly
depend on PPC32



Le 01/11/2019 à 13:42, Rasmus Villemoes a écrit :

quoted

Currently, FSL_UCC_HDLC depends on QUICC_ENGINE, which in turn

depends

quoted

on PPC32. As preparation for removing the latter and thus allowing
the core QE code to be built for other architectures, make
FSL_UCC_HDLC explicitly depend on PPC32.

Is that really powerpc specific ? Can't the ARM QE perform HDLC on UCC ?

I think the driver would build on ARM. Whether it works I don't know. I know it
does not build on 64 bit hosts (see kbuild report for v2,23/23).

quoted

No.  Actually the HDLC and TDM are the major reason to integrate a QE on

the ARM based Layerscape SoCs.

[citation needed].

quoted

Since Rasmus doesn't have the hardware to test this feature Qiang Zhao

probably can help verify the functionality of TDM and we can drop this patch.

No, this patch cannot be dropped. Please see the kbuild complaints for
v2,23/23 about use of IS_ERR_VALUE on not-sizeof(long) entities. I see kbuild
has complained about the same thing for v3 since apparently the same thing
appears in ucc_slow.c. So I'll fix that.

Moreover, as you say and know, I do not have the hardware to test it, so I'm
not going to even attempt to fix up fsl_ucc_hdlc.c. If Qiang Zhao or somebody
else can verify that it works just fine on ARM and fixes the allmodconfig
problem(s), he/she is more than welcome to sign off on a patch that removes
the CONFIG_PPC32 dependency or replaces it with something else.

I tested your v3 patches on ls1043ardb which is arm64 for fsl_ucc_hdlc, it can work,
Only it will put a compile warning, I also made a patch to fix it.
I can send a patch to remove PPC32 dependency when I send my patch to support ARM64.
Or I add my patch in your patchset.

Best Regards
Qiang Zhao
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel