On Sun, 27 Oct 2019 at 14:05, Christophe Leroy [off-list ref] wrote:

Le 27/10/2019 à 12:05, Ard Biesheuvel a écrit :

quoted

On Sun, 27 Oct 2019 at 11:45, Christophe Leroy [off-list ref] wrote:

quoted

Le 24/10/2019 à 15:23, Ard Biesheuvel a écrit :

quoted

Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
dated 20 august 2015 introduced the new skcipher API which is supposed to
replace both blkcipher and ablkcipher. While all consumers of the API have
been converted long ago, some producers of the ablkcipher remain, forcing
us to keep the ablkcipher support routines alive, along with the matching
code to expose [a]blkciphers via the skcipher API.

So switch this driver to the skcipher API, allowing us to finally drop the
blkcipher code in the near future.

Signed-off-by: Ard Biesheuvel <redacted>

With this series, I get the following Oops at boot:

Thanks for the report.

Given that the series only modifies ablkcipher implementations, it is
rather curious that the crash occurs in ahash_init(). Can you confirm
that the crash does not occur with this patch reverted?

Yes I confirm.

You changed talitos_cra_init_ahash(). talitos_init_common() is not
called anymore. I think that's the reason.

Thanks a lot for digging into this

Does this fix things for you?

index c29f8c02ea05..d71d65846e47 100644

--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c

@@ -3053,7 +3053,7 @@ static int talitos_cra_init_ahash(struct crypto_tfm *tfm)
        crypto_ahash_set_reqsize(__crypto_ahash_cast(tfm),
                                 sizeof(struct talitos_ahash_req_ctx));

-       return 0;
+       return talitos_init_common(ctx, talitos_alg);
 }

 static void talitos_cra_exit(struct crypto_tfm *tfm)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel