Re: [PATCH] clk: sunxi-ng: a80: fix the zero'ing of bits 16 and 18
From: Maxime Ripard <mripard@kernel.org>
Date: 2019-10-29 07:48:37
Also in:
kernel-janitors, linux-clk, lkml
On Wed, Oct 23, 2019 at 12:28:09PM +0100, Colin King wrote:
From: Colin Ian King <redacted>
The zero'ing of bits 16 and 18 is incorrect. Currently the code
is masking with the bitwise-and of BIT(16) & BIT(18) which is
0, so the updated value for val is always zero. Fix this by bitwise
and-ing value with the correct mask that will zero bits 16 and 18.
Addresses-Coverity: (" Suspicious &= or |= constant expression")
Fixes: b8eb71dcdd08 ("clk: sunxi-ng: Add A80 CCU")
Signed-off-by: Colin Ian King <redacted>Applied, thanks! Maxime