Re: [PATCH v2 02/29] powerpc: Remove PT_NOTE workaround
From: Kees Cook <hidden>
Date: 2019-10-11 16:09:27
Also in:
linux-alpha, linux-arch, linux-s390, linuxppc-dev, lkml
From: Kees Cook <hidden>
Date: 2019-10-11 16:09:27
Also in:
linux-alpha, linux-arch, linux-s390, linuxppc-dev, lkml
On Fri, Oct 11, 2019 at 05:07:04PM +1100, Michael Ellerman wrote:
Kees Cook [off-list ref] writes:quoted
In preparation for moving NOTES into RO_DATA, remove the PT_NOTE workaround since the kernel requires at least gcc 4.6 now. Signed-off-by: Kees Cook <redacted> --- arch/powerpc/kernel/vmlinux.lds.S | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-)Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Thanks!
For the archives, Joel tried a similar patch a while back which caused some problems, see: https://lore.kernel.org/linuxppc-dev/20190321003253.22100-1-joel@jms.id.au/ (local) and a v2: https://lore.kernel.org/linuxppc-dev/20190329064453.12761-1-joel@jms.id.au/ (local) This is similar to his v2. The only outstanding comment on his v2 was from Segher: (And I do not know if there are any tools that expect the notes in a phdr, or even specifically the second phdr). But this patch solves that by not changing the note.
Ah yes. Agreed: I'm retaining the note and dropping the workarounds. FWIW, this builds happily for me in my tests. -Kees -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel