Re: [PATCH] staging: media: sunxi: make use of devm_platform_ioremap_resource
From: Paul Kocialkowski <hidden>
Date: 2019-10-08 07:11:14
Also in:
linux-media, lkml
Hi, On Tue 08 Oct 19, 12:29, hariprasadKelamhariprasad.kelam@gmail.com wrote:
From: Hariprasad Kelam <redacted> fix below issue reported by coccicheck drivers/staging//media/sunxi/cedrus/cedrus_hw.c:229:1-10: WARNING: Use devm_platform_ioremap_resource for dev -> base
Looks good, thanks! Acked-by: Paul Kocialkowski <redacted> Cheers, Paul
quoted hunk
Signed-off-by: Hariprasad Kelam <redacted> --- drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c index a942cd9..f19b87c 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c@@ -146,7 +146,6 @@ static irqreturn_t cedrus_irq(int irq, void *data) int cedrus_hw_probe(struct cedrus_dev *dev) { const struct cedrus_variant *variant; - struct resource *res; int irq_dec; int ret;@@ -225,8 +224,7 @@ int cedrus_hw_probe(struct cedrus_dev *dev) goto err_sram; } - res = platform_get_resource(dev->pdev, IORESOURCE_MEM, 0); - dev->base = devm_ioremap_resource(dev->dev, res); + dev->base = devm_platform_ioremap_resource(dev->pdev, 0); if (IS_ERR(dev->base)) { dev_err(dev->dev, "Failed to map registers\n");-- 2.7.4
-- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com