Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

On 01/10/2019 18:14, Jeffrey Hugo wrote:

On Tue, Oct 1, 2019 at 11:04 AM Sai Prakash Ranjan
[off-list ref] wrote:

quoted

On 2019-10-01 09:13, Jeffrey Hugo wrote:

quoted

Sai,

This patch breaks boot on the 835 laptops.  However, I haven't seen
the same issue on the MTP.  I wonder, is coresight expected to work
with production fused devices?  I wonder if thats the difference
between the laptop and MTP that is causing the issue.

Let me know what I can do to help debug.

I did test on MSM8998 MTP and didn't face any issue. I am guessing this
is the same issue which you reported regarding cpuidle? Coresight ETM

Yes, its the same issue.  Right now, I need both patches reverted to boot.

quoted

and cpuidle do not work well together since ETMs share the same power
domain as CPU and they might get turned off when CPU enters idle states.
Can you try with cpuidle.off=1 cmdline or just remove idle states from
DT to confirm? If this is the issue, then we can try the below patch
from Andrew Murray for ETM save and restore:

https://patchwork.kernel.org/patch/11097893/

Is there still value in testing this if the idle states are removed,
yet the coresight nodes still cause issues?

Funny enough, I'm using the arm64 defconfig which doesn't seem to
select CONFIG_CORESIGHT, so I'm not even sure what would be binding to
the DT devices...

That looks like potentially missing Power domain support, either in the kernel
or from the firmware.

The Coresight components are also AMBA devices (with primecell compatible)
and thus the AMBA bus layer does some probing to check the PIDRx registers
to match the driver. The AMBA layer does try to get the power to the
component, but someone is lying that it is powered.

Suzuki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel