Re: [PATCH v3] PCI: aardvark: Don't rely on jiffies while holding spinlock
From: Andrew Murray <hidden>
Date: 2019-09-30 14:50:03
Also in:
linux-pci, lkml
On Fri, Sep 27, 2019 at 11:45:55AM +0200, Thomas Petazzoni wrote:
On Fri, 27 Sep 2019 10:55:02 +0200 Remi Pommarel [off-list ref] wrote:quoted
advk_pcie_wait_pio() can be called while holding a spinlock (from pci_bus_read_config_dword()), then depends on jiffies in order to timeout while polling on PIO state registers. In the case the PIO transaction failed, the timeout will never happen and will also cause the cpu to stall. This decrements a variable and wait instead of using jiffies. Signed-off-by: Remi Pommarel <redacted>Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: Andrew Murray <redacted>
Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel