Re: [PATCH] seccomp: remove unused arg from secure_computing()
From: Christian Brauner <hidden>
Date: 2019-09-24 06:19:57
Also in:
linux-s390, linux-um, lkml
On Mon, Sep 23, 2019 at 09:34:46PM +0200, Borislav Petkov wrote:
On Mon, Sep 23, 2019 at 11:41:59AM -0700, Andy Lutomirski wrote:quoted
On Mon, Sep 23, 2019 at 2:49 AM Borislav Petkov [off-list ref] wrote:quoted
On Fri, Sep 20, 2019 at 03:19:09PM +0200, Christian Brauner wrote:quoted
While touching seccomp code I realized that the struct seccomp_data argument to secure_computing() seems to be unused by all current callers. So let's remove it unless there is some subtlety I missed. Note, I only tested this on x86.What was amluto thinking in 2f275de5d1ed ("seccomp: Add a seccomp_data parameter secure_computing()")IIRC there was a period of time in which x86 used secure_computing() for normal syscalls, and it was a good deal faster to have the arch code supply seccomp_data. x86 no longer works like this, and syscalls aren't fast anymore ayway :(Uhuh, thanks Andy. Christian, pls add that piece of history to the commit message.
Yip, will do. Thanks! Christian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel