Hi, Pavel

Subject: Re: [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding

On Tue 2019-09-03 10:03:40, Anson Huang wrote:

quoted

NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system
controller, the system controller is in charge of system power, clock
and power key event etc. management, Linux kernel has to communicate
with system controller via MU (message unit) IPC to get power key
event, add binding doc for i.MX system controller power key driver.

Signed-off-by: Anson Huang <redacted>
---
Changes since V1:
	- remove "wakeup-source" property, as it is NOT needed for SCU

interrupt;

quoted

	- remove "status" in example.
---
 .../devicetree/bindings/arm/freescale/fsl,scu.txt          | 14

++++++++++++++

quoted

 1 file changed, 14 insertions(+)

diff --git
a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index c149fad..f93e2e4 100644

--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt

@@ -157,6 +157,15 @@ Required properties:
 Optional properties:
 - timeout-sec: contains the watchdog timeout in seconds.

+Power key bindings based on SCU Message Protocol
+------------------------------------------------------------
+
+Required properties:
+- compatible: should be:
+              "fsl,imx8qxp-sc-pwrkey"
+              followed by "fsl,imx-sc-pwrkey";
+- linux,keycodes: See
+Documentation/devicetree/bindings/input/keys.txt

Note you have keycode_s_ here, but keycode in the example and in the dts
patch.

NOT quite understand your point, could you please provide more details?

Thanks,
Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel