Re: [PATCH] staging: mt7621-pci-phy: Use devm_platform_ioremap_resource() in mt7621_pci_phy_probe()
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date: 2019-09-19 04:20:52
Also in:
kernel-janitors, linux-mediatek, lkml
Hi Markus, Thanks for the patch. It looks good to me. On Wed, Sep 18, 2019 at 9:12 PM Markus Elfring [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Markus Elfring <redacted> Date: Wed, 18 Sep 2019 21:01:32 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted> --- drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)diff --git a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c index d2a07f145143..6ca4a33d13c3 100644 --- a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c +++ b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c@@ -324,7 +324,6 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev) const struct soc_device_attribute *attr; struct phy_provider *provider; struct mt7621_pci_phy *phy; - struct resource *res; int port; void __iomem *port_base;@@ -344,14 +343,7 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev) phy->dev = dev; platform_set_drvdata(pdev, phy); - - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(dev, "failed to get address resource\n"); - return -ENXIO; - } - - port_base = devm_ioremap_resource(dev, res); + port_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(port_base)) { dev_err(dev, "failed to remap phy regs\n"); return PTR_ERR(port_base); --2.23.0
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel