Re: [PATCH v5 1/8] clk: Zero init clk_init_data in helpers
From: Stephen Boyd <sboyd@kernel.org>
Date: 2019-09-17 20:39:59
Also in:
linux-clk, linux-devicetree, lkml
Quoting Manivannan Sadhasivam (2019-09-16 09:14:40)
quoted hunk ↗ jump to hunk
The clk_init_data struct needs to be initialized to zero for the new parent_map implementation to work correctly. Otherwise, the member which is available first will get processed. Signed-off-by: Manivannan Sadhasivam <redacted> --- drivers/clk/clk-composite.c | 2 +- drivers/clk/clk-divider.c | 2 +- drivers/clk/clk-fixed-rate.c | 2 +- drivers/clk/clk-gate.c | 2 +- drivers/clk/clk-mux.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c index b06038b8f658..4d579f9d20f6 100644 --- a/drivers/clk/clk-composite.c +++ b/drivers/clk/clk-composite.c@@ -208,7 +208,7 @@ struct clk_hw *clk_hw_register_composite(struct device *dev, const char *name, unsigned long flags) { struct clk_hw *hw; - struct clk_init_data init; + struct clk_init_data init = { NULL };
I'd prefer { } because then we don't have to worry about ordering the
struct to have a pointer vs. something else first.
struct clk_composite *composite;
struct clk_ops *clk_composite_ops;
int ret;_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel