Re: [PATCH] iommu/arm-smmu: Axe a useless test in 'arm_smmu_master_alloc_smes()'
flat view
From: Robin Murphy <robin.murphy@arm.com>
Date: 2019-09-16 10:46:17
Also in:
kernel-janitors, linux-iommu, lkml
On 15/09/2019 20:34, Christophe JAILLET wrote:
'ommu_group_get_for_dev()' never returns NULL, so this test can be removed.
Nit: typo in the function name. Otherwise, there definitely used to be some path where a NULL return could leak out, so I would have had that in mind at the time I wrote this, but apparently I never noticed that that had already been cleaned up by the time this got merged. Reviewed-by: Robin Murphy <robin.murphy@arm.com> Thanks, Robin.
quoted hunk ↗ jump to hunk
Signed-off-by: Christophe JAILLET <redacted> --- drivers/iommu/arm-smmu.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index c3ef0cc8f764..6fae8cdbe985 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c@@ -1038,8 +1038,6 @@ static int arm_smmu_master_alloc_smes(struct device *dev) } group = iommu_group_get_for_dev(dev); - if (!group) - group = ERR_PTR(-ENOMEM); if (IS_ERR(group)) { ret = PTR_ERR(group); goto out_err;
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel