Re: [PATCHv1 3/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to HDMI supply
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: 2019-09-01 11:44:58
Also in:
linux-amlogic, linux-devicetree, lkml
Hi Anand, On Wed, Aug 28, 2019 at 10:27 PM Anand Moon [off-list ref] wrote:
As per shematics HDMI_P5V0 is supplied by P5V0 so add missing link.
typo: "schematics"
quoted hunk ↗ jump to hunk
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Jerome Brunet <jbrunet@baylibre.com> Cc: Neil Armstrong <redacted> Signed-off-by: Anand Moon <redacted> --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 ++ 1 file changed, 2 insertions(+)diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index a078a1ee5004..47789fd50415 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts@@ -213,6 +213,8 @@ status = "okay"; pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>; pinctrl-names = "default"; + /* AP2331SA-7 */ + hdmi-supply = <&p5v0>; };
my understanding based on odroid-c2_rev0.1_20150930.pdf is that: - there's a (fixed) hdmi_p5v0 regulator using p5v0 as input - the hdmi_p5v0 is the hdmi-supply it doesn't change the functionality of this patch (since both supplies are fixed regulators anyways) you are already doing a nice cleanup with this series, so it would be a shame to take a shortcut here Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel